feat: core-owned supported hardware-wallet catalog (#107 subtask 4)#111
Open
coreyphillips wants to merge 1 commit into
Open
feat: core-owned supported hardware-wallet catalog (#107 subtask 4)#111coreyphillips wants to merge 1 commit into
coreyphillips wants to merge 1 commit into
Conversation
Adds get_supported_hardware_wallets(), backed by HardwareWalletVendor and SupportedHardwareWallet, so iOS and Android render the supported-device catalog from core instead of each hardcoding Trezor metadata (follow-up from synonymdev/bitkit-android#1039). Catalog is Trezor's full lineup (Model One, Model T, Safe 3, Safe 5, Safe 7), each with the transports it supports. Only the Safe 7 offers Bluetooth, so iOS (Bluetooth-only) filters to it while Android shows all — platforms filter on `transports`, keeping core platform-agnostic. Bumps version to 0.3.5 and regenerates all platform bindings + native artifacts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subtask 4 of #107. Core now owns the catalog of supported hardware wallets, so iOS and Android render the supported-device list generically instead of each hardcoding Trezor metadata. Follow-up from the review note on synonymdev/bitkit-android#1039 ("this could come from Bitkit-core in the future, because it is where all supported HW info is actually located").
What changed
New UniFFI surface in the trezor module (re-exported from
lib.rs):Catalog (Trezor's full lineup):
Platform handling
Core stays platform-agnostic. Apps filter on
transports:transportsincludeBluetooth(currently just the Safe 7).Notes
TrezorFeatureson a connected device, so the catalog only needs identity + transports. Apps mapmodelto their own bundled images.build.sh all, and thePackage.swiftchecksum matches the rebuiltBitkitCore.xcframework.zip.Tests
cargo test --lib supported_hardware_wallets— asserts the lineup, well-formed entries (USB on every model,display_name="Trezor {model}"), and that the Bluetooth-capable filter yields exactly the Safe 7.🤖 Generated with Claude Code