Skip to content

fix: use core LNURL-pay validation#607

Merged
piotr-iohk merged 1 commit into
ovi/release-2.3.0from
fix/lnurl-pay
Jun 26, 2026
Merged

fix: use core LNURL-pay validation#607
piotr-iohk merged 1 commit into
ovi/release-2.3.0from
fix/lnurl-pay

Conversation

@ovitrif

@ovitrif ovitrif commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR:

  1. Updates the app from iOS release v2.3.0 to bitkit-core 0.1.74.
  2. Routes LNURL-pay invoice fetching through generated core bindings with full LnurlPayData.
  3. Removes local LNURL-pay invoice callback fetching while leaving withdraw/channel behavior unchanged.
  4. Handles core invoice validation errors with a neutral payment-canceled message.

Patch commit: c522b5cc3cc223bc87e0158cfe749129eac83844
Core release: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.74

Linked Issues/Tasks

Refs:

Screenshot / Video

N/A

QA Notes

Manual Tests

  • 1. Send -> scan LNURL-pay request -> complete payment: invoice fetch and send behavior match the requested payment.
  • 2. regression: Send -> scan LNURL-withdraw or LNURL-channel request: existing withdraw/channel behavior still works.

Automated Checks

  • Local verification: swiftformat --lint for touched Swift files, xcodebuild build.
  • Runtime proof: Android and iOS before/after LNURL-pay validation recordings completed locally.

@greptile-apps

This comment has been minimized.

greptile-apps[bot]

This comment was marked as resolved.

@ovitrif ovitrif changed the base branch from master to ovi/release-2.3.0 June 25, 2026 22:27
@ovitrif ovitrif self-assigned this Jun 25, 2026
@ovitrif ovitrif requested review from piotr-iohk and pwltr June 25, 2026 23:22

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few nits that must be addressed. PR changes should be squashed into a single commit with same message as PR name

Comment thread Bitkit/ViewModels/Trezor/TrezorViewModel.swift
@ovitrif

ovitrif commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

added a few nits that must be addressed. PR changes should be squashed into a single commit with same message as PR name

Addressed the review thread and squashed the branch into a single commit named fix: use core LNURL-pay validation.

Resolved in c522b5c

@piotr-iohk piotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Staging regtest: normal LN + QuickPay on/off OK. CI @lnurl_1 passed — sufficient regression for the LNURL-pay validation hotfix. Good to merge once all e2e pass.

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck, Changes looks solid and self contained

@piotr-iohk piotr-iohk merged commit be27a0b into ovi/release-2.3.0 Jun 26, 2026
15 of 17 checks passed
@piotr-iohk piotr-iohk deleted the fix/lnurl-pay branch June 26, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants