fix: use core LNURL-pay validation#607
Merged
Merged
Conversation
This was referenced Jun 25, 2026
This comment has been minimized.
This comment has been minimized.
ovitrif
commented
Jun 25, 2026
ovitrif
left a comment
Collaborator
Author
There was a problem hiding this comment.
added a few nits that must be addressed. PR changes should be squashed into a single commit with same message as PR name
Collaborator
Author
Addressed the review thread and squashed the branch into a single commit named Resolved in c522b5c |
piotr-iohk
approved these changes
Jun 26, 2026
piotr-iohk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Staging regtest: normal LN + QuickPay on/off OK. CI @lnurl_1 passed — sufficient regression for the LNURL-pay validation hotfix. Good to merge once all e2e pass.
pwltr
approved these changes
Jun 26, 2026
jvsena42
approved these changes
Jun 26, 2026
jvsena42
left a comment
Member
There was a problem hiding this comment.
utAck, Changes looks solid and self contained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
v2.3.0tobitkit-core0.1.74.LnurlPayData.Patch commit:
c522b5cc3cc223bc87e0158cfe749129eac83844Core release: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.74
Linked Issues/Tasks
Refs:
Screenshot / Video
N/A
QA Notes
Manual Tests
regression:Send -> scan LNURL-withdraw or LNURL-channel request: existing withdraw/channel behavior still works.Automated Checks
swiftformat --lintfor touched Swift files,xcodebuild build.