Skip to content

Brush extents fire events fix #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Git-me-outta-here wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Brush extents fire events fix #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954937d
Merge pull request #1 from syntagmatic/master
Git-me-outta-here May 18, 2017
52bf392
brushExtents now fires events only after all new extents have been se…
Git-me-outta-here May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions d3.parcoords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,9 +1213,13 @@ pc.brushMode = function(mode) {
.transition()
.duration(0)
.call(brush);

//fire some events
brush.event(brushSelections[d]);
}
});

//now all brush extents have been updated: fire some events
d3.keys(brushes).forEach(function(d) {
if (brushes[d] !== undefined || extents[d] === undefined) {
brushes[d].event(brushSelections[d]);
}
});

Expand Down Expand Up @@ -1751,9 +1755,13 @@ pc.brushMode = function(mode) {
.transition()
.duration(0)
.call(brush);

//fire some events
brush.event(brushSelections[d]);
}
});

//now all brush extents have been updated: fire some events
d3.keys(brushes).forEach(function(d) {
if (brushes[d] !== undefined || extents[d] === undefined) {
brushes[d].event(brushSelections[d]);
}
});

Expand Down
10 changes: 7 additions & 3 deletions src/brushes/1D.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,13 @@
.transition()
.duration(0)
.call(brush);

//fire some events
brush.event(brushSelections[d]);
}
});

//now all brush extents have been updated: fire some events
d3.keys(brushes).forEach(function(d) {
if (brushes[d] !== undefined || extents[d] === undefined) {
brushes[d].event(brushSelections[d]);
}
});

Expand Down
10 changes: 7 additions & 3 deletions src/brushes/1D.multi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,13 @@
.transition()
.duration(0)
.call(brush);

//fire some events
brush.event(brushSelections[d]);
}
});

//now all brush extents have been updated: fire some events
d3.keys(brushes).forEach(function(d) {
if (brushes[d] !== undefined || extents[d] === undefined) {
brushes[d].event(brushSelections[d]);
}
});

Expand Down