Skip to content

The Machine: Fixup issues with the machine#783

Merged
stack72 merged 1 commit intomainfrom
fixup-look-sharp
Mar 19, 2026
Merged

The Machine: Fixup issues with the machine#783
stack72 merged 1 commit intomainfrom
fixup-look-sharp

Conversation

@stack72
Copy link
Contributor

@stack72 stack72 commented Mar 19, 2026

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve

Clean, focused infrastructure PR. No blocking issues.

What this does

  • Removes 2>/dev/null from post-edit hooks — errors are now visible for debugging
  • Removes per-file deno check from the post-edit hook (project-wide check in stop hook is sufficient)
  • Switches deno lintdeno lint --fix in post-edit hook (correct for auto-fix context)
  • Switches stop hook and CI to deno task commands for consistency with deno.json
  • Adds missing deno task check step to CI (was absent before — good catch)
  • Updates CLAUDE.md documentation to match

Suggestion (non-blocking)

The Verification section in CLAUDE.md (line 62-63) still references deno check and deno run test for the stop hook, but the hook now uses deno task check and deno task test. Could update for precision, but functionally equivalent.

🤖 Generated with Claude Code

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review

Critical / High

None.

Medium

  1. CLAUDE.md Verification section is now inaccurate — The Verification section still reads: "A Stop hook ... runs project-wide deno check, deno lint, and deno run test" — but after this PR, stop-verify.sh runs deno task check (which is deno check main.ts, not bare deno check) and deno task test (not deno run test). Since CLAUDE.md is the primary instruction source for AI agents working on this repo, stale instructions here could cause confusion in future sessions. The fix is trivial: update those references in the Verification section to match reality.

Low

  1. deno task check narrows type-check scope vs bare deno checkdeno task check runs deno check main.ts, which only type-checks files transitively imported from main.ts. Bare deno check (Deno ≥1.x with deno.json) checks all files matching the project config. Standalone scripts in scripts/ or test files not reachable from main.ts would no longer be type-checked in the stop hook or CI. This is likely intentional (and those scripts are in the exclude list anyway), but worth confirming.

Verdict

PASS — Straightforward cleanup. The hook changes are correct (removing stderr suppression, dropping per-file deno check from the hot path, adding --fix to lint). CI changes correctly centralize on deno task definitions. The only actionable item is updating the CLAUDE.md Verification section to match the new commands.

@stack72 stack72 merged commit 16f2cc4 into main Mar 19, 2026
8 checks passed
@stack72 stack72 deleted the fixup-look-sharp branch March 19, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant