Conversation
There was a problem hiding this comment.
Review: Approve
Clean, focused infrastructure PR. No blocking issues.
What this does
- Removes
2>/dev/nullfrom post-edit hooks — errors are now visible for debugging - Removes per-file
deno checkfrom the post-edit hook (project-wide check in stop hook is sufficient) - Switches
deno lint→deno lint --fixin post-edit hook (correct for auto-fix context) - Switches stop hook and CI to
deno taskcommands for consistency withdeno.json - Adds missing
deno task checkstep to CI (was absent before — good catch) - Updates CLAUDE.md documentation to match
Suggestion (non-blocking)
The Verification section in CLAUDE.md (line 62-63) still references deno check and deno run test for the stop hook, but the hook now uses deno task check and deno task test. Could update for precision, but functionally equivalent.
🤖 Generated with Claude Code
There was a problem hiding this comment.
Adversarial Review
Critical / High
None.
Medium
- CLAUDE.md Verification section is now inaccurate — The Verification section still reads: "A Stop hook ... runs project-wide
deno check,deno lint, anddeno run test" — but after this PR,stop-verify.shrunsdeno task check(which isdeno check main.ts, not baredeno check) anddeno task test(notdeno run test). Since CLAUDE.md is the primary instruction source for AI agents working on this repo, stale instructions here could cause confusion in future sessions. The fix is trivial: update those references in the Verification section to match reality.
Low
deno task checknarrows type-check scope vs baredeno check—deno task checkrunsdeno check main.ts, which only type-checks files transitively imported frommain.ts. Baredeno check(Deno ≥1.x withdeno.json) checks all files matching the project config. Standalone scripts inscripts/or test files not reachable frommain.tswould no longer be type-checked in the stop hook or CI. This is likely intentional (and those scripts are in theexcludelist anyway), but worth confirming.
Verdict
PASS — Straightforward cleanup. The hook changes are correct (removing stderr suppression, dropping per-file deno check from the hot path, adding --fix to lint). CI changes correctly centralize on deno task definitions. The only actionable item is updating the CLAUDE.md Verification section to match the new commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.