Skip to content

The Machine: Skip Claude hooks in CI reviews#789

Merged
stack72 merged 1 commit intomainfrom
no-hooks-in-ci
Mar 20, 2026
Merged

The Machine: Skip Claude hooks in CI reviews#789
stack72 merged 1 commit intomainfrom
no-hooks-in-ci

Conversation

@stack72
Copy link
Contributor

@stack72 stack72 commented Mar 20, 2026

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clean, minimal change that correctly skips Claude hooks in CI.

Review notes:

  • ${CI:-} safely handles unset variables — no set -u violations
  • exit 0 is the right exit code (non-zero would block Claude operations)
  • Placement in both scripts is correct — early exit before any work is done
  • No domain code, so DDD considerations don't apply
  • Shell scripts don't require license headers, formatting, or lint checks

No blocking issues. Ship it! 🚢

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review

Critical / High

None.

Medium

None.

Low

  1. .claude/hooks/post-edit-format.sh / .claude/hooks/stop-verify.sh: A developer who sets CI=true locally (e.g., from a prior debugging session or dotfile) would silently skip all formatting and verification hooks with no feedback. This is purely theoretical — the hooks aren't security controls and the developer would notice when their commits fail CI — but a # Note: set CI=true to skip comment could prevent confusion. Not worth blocking.

Verdict

PASS — Minimal, correct change. The ${CI:-} pattern correctly handles unset variables under set -u, placement before stdin reads avoids blocking, and the hooks are convenience-only (CI runs its own checks). No issues found.

@stack72 stack72 merged commit 170e598 into main Mar 20, 2026
6 checks passed
@stack72 stack72 deleted the no-hooks-in-ci branch March 20, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant