Conversation
There was a problem hiding this comment.
Looks good! Clean, minimal change that correctly skips Claude hooks in CI.
Review notes:
${CI:-}safely handles unset variables — noset -uviolationsexit 0is the right exit code (non-zero would block Claude operations)- Placement in both scripts is correct — early exit before any work is done
- No domain code, so DDD considerations don't apply
- Shell scripts don't require license headers, formatting, or lint checks
No blocking issues. Ship it! 🚢
There was a problem hiding this comment.
Adversarial Review
Critical / High
None.
Medium
None.
Low
.claude/hooks/post-edit-format.sh/.claude/hooks/stop-verify.sh: A developer who setsCI=truelocally (e.g., from a prior debugging session or dotfile) would silently skip all formatting and verification hooks with no feedback. This is purely theoretical — the hooks aren't security controls and the developer would notice when their commits fail CI — but a# Note: set CI=true to skipcomment could prevent confusion. Not worth blocking.
Verdict
PASS — Minimal, correct change. The ${CI:-} pattern correctly handles unset variables under set -u, placement before stdin reads avoids blocking, and the hooks are convenience-only (CI runs its own checks). No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.