feat: add k8s deployment, session expiry, and logout button#881
Open
midy177 wants to merge 4 commits into
Open
feat: add k8s deployment, session expiry, and logout button#881midy177 wants to merge 4 commits into
midy177 wants to merge 4 commits into
Conversation
added 4 commits
June 8, 2026 16:41
- deploy/k8s: add Kubernetes manifests (Deployment, Service, ConfigMap) with emptyDir storage and startup script to inject PG/Redis connections via API; supports standalone, sentinel, and cluster Redis modes - auth: replace HashSet<String> sessions with HashMap<String, Instant>; sessions expire after DBX_SESSION_TTL_HOURS (default 12h); hourly background purge task added - feat(toolbar): add logout button shown only when auth is required - deploy/Dockerfile: add curl and jq to runtime stage; fix cross-compile deps for building amd64 on arm64 hosts
t8y2
requested changes
Jun 9, 2026
t8y2
left a comment
t8y2
left a comment
Owner
There was a problem hiding this comment.
🔴 Must Fix
1. CI failures
- Frontend:
AppToolbar.vuefailed format check — run prettier to fix - Rust: compilation error in tests —
connection.rs:214still usesHashSet::new()butWebState.sessionshas been changed toHashMap<String, Instant>. Replace it withHashMap::new()
2. Hardcoded password in deployment.yaml
- name: DBX_PASSWORD
value: "ZpFoJGrche4lrUj0"Real passwords should not be committed. Use a placeholder or a Kubernetes Secret instead.
3. Private registry references in README.md and deployment.yaml
hub.yeastardigital.com/novo-middleware/dbx:latest is an internal registry. Public repo docs and manifests should use a generic image name (e.g. t8y2/dbx or a placeholder).
🟡 Suggestions
4. Three unrelated changes in one PR (K8s deployment, session expiry, logout button) — consider splitting into separate PRs for easier review and rollback
✅ Well Done
- Session expiry design is clean:
HashMap<String, Instant>replacingHashSet<String>, withDBX_SESSION_TTL_HOURSenv var and background cleanup is_session_validandpurge_expired_sessionsencapsulated onWebState, clear separation of concerns- Logout button only shown when
needsAuthis true - i18n covers en + zh-CN
t8y2
force-pushed
the
main
branch
6 times, most recently
from
0eb730f to
c9b3292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add k8s deployment, session expiry, and logout button