Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3360
When importing a recovery phrase, a typo, an unknown word and a checksum failure all showed the same "Invalid recovery phrase" error, so it is hard for users to tell which word was wrong. This checks each word against the BIP39 English list as one type and suggests words from it.
This is behind a new flag,
SUPPORT_SEED_WORD_SUGGESTIONS, which is off by default:Features added
The word list is the same one
isValidMnemonicuses, taken fromethers, so no new dependency. The phrase stays in component state, therefore, no Redux, storage, analytics or logging, and browser spellcheck and autofill are off.Underlining the wrong word inside the box is not covered in this PR.
Below is a video showing the added features when the feature flag is turned on for testing.
screen.recording.mp4