fix: compare_windows uses rate-of-change for counter metrics#31
Merged
Conversation
Series API has no rate() — PMAPI has it but is live-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26.
pcp_compare_windowswas comparing raw cumulative counter values across windows — counters are monotonic odometers, so comparing means is meaningless (a counter at 1M vs 2M looks like "2x increase" when the rate was identical)/series/descs, detects counters, and computes rate-of-change before stats comparisonChanges
_compute_rates()in_stats.py— converts timestamped counter samples to per-second rates, clamps to zero on counter wraps, skips zero-dt pairs_fetch_descs()in_fetch.py— fetches metric semantics from/series/descswith graceful fallback to "instant" on error_compare_windows_impl()incomparison.py— builds semantics-by-key map, rate-converts counters, adds"semantics"field to output/series/descsas[]→ defaults to instant)Test plan
_compute_rates: empty, single, monotonic, counter wrap, zero-dt, steady rate_fetch_descs: happy path, empty input, pmproxy error fallbackPMPROXY_URLset)