Skip to content

Remove git submodules in favor of DVC#71

Draft
nepoche wants to merge 3 commits intomainfrom
nathan/use-dvc-fixtures
Draft

Remove git submodules in favor of DVC#71
nepoche wants to merge 3 commits intomainfrom
nathan/use-dvc-fixtures

Conversation

@nepoche
Copy link

@nepoche nepoche commented Sep 1, 2022

No description provided.

@drewstone
Copy link
Contributor

@nepoche any chance you can fix up the test script/fixtures issues? Seems a bunch of repos with this change need it also handled in the test CI script.

@duguorong009
Copy link
Contributor

duguorong009 commented Sep 27, 2022

@drewstone @nepoche
The reason of CI failure is from that the name of original submodule dir(substrate-fixtures) does not match with new one(protocol-substrate-fixtures).
So, it should replace all the lines which have the ../substrate-fixtures/... with new name ../protocol-substrate-fixtures/....
For example: In this line, it should be like

(2, 2, 2) =>  include_bytes!("../../../protocol-substrate-fixtures/vanchor/bn254/x5/2-2-2/verifying_key.bin"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants