Repository navigation
feat(datafusion): Allow to iterate over predicates got from filters - #12
Merged
askalt merged 1 commit intoJun 10, 2026
Merged
Conversation
Prior the patch incoming filters were filtered and reduced before return. This approach hides information about which particular filter can be converted. A new introduced function returns an iterator of optional filters: * `None` - same positioned input filter cannot be converted, * `Some(predicate)` - filter has been converted to predicate. Old function is kept and re-uses the new function under the hood.
aectaan
approved these changes
Jun 9, 2026
kryvashek
reviewed
Jun 10, 2026
Member
|
Thank you for the patch! I have the only comment you can see above, anything else LGTM. |
kryvashek
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Prior the patch incoming filters were filtered and reduced before return.
This approach hides information about which particular filter can be converted.
What changes are included in this PR?
A new introduced function returns an iterator of optional filters:
None- same positioned input filter cannot be converted,Some(predicate)- filter has been converted to predicate.Old function is kept and re-uses the new function under the hood.
Are these changes tested?
Unit testing includes tests of the new function.