Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various RFC documents to reflect architectural changes, including renaming the Digital Assets Network (DAN) to Ootle, updating Proof of Work algorithms, and adding an HTTP API specification. The review identified two issues: a typo in a percentage notation in the overview document and a missing space in a domain-separated hash description in the consensus document.
| Tari is mined using a hybrid approach. On average, 50% of block rewards come from [Monero merge-mining], | ||
| while 50% come from the [Sha3x][RFC-131] algorithm. Blocks are produced every 2 minutes, on average. | ||
| Tari is mined using a hybrid approach. On average, 25% of block rewards come from [Monero merge-mining], | ||
| 25& solo mined using RandomX, 25% mined using Cuckaroo 29 and 25% come from the [Sha3x][RFC-131] algorithm. |
There was a problem hiding this comment.
Typo in percentage notation: '25&' should be '25%'.
Suggested change
| 25& solo mined using RandomX, 25% mined using Cuckaroo 29 and 25% come from the [Sha3x][RFC-131] algorithm. | |
| 25% solo mined using RandomX, 25% mined using Cuckaroo 29 and 25% come from the [Sha3x][RFC-131] algorithm. |
| * each [transaction output] MUST: | ||
| * be of an allowed [transaction output] version | ||
| * have a unique domain separated hash (`version || features || commitment || script || covenant || encrypted_values`) with the domain (`transaction_output`) | ||
| * have a unique domain-separated hash (`version || features || commitment|| RangeProof Hash || Sender Offset Public Key || Metadata signature || script || covenant || encrypted_data || minimum value promise`) with the domain (`transaction_output`) |
There was a problem hiding this comment.
There is a missing space between 'commitment' and '||' in the domain-separated hash description.
Suggested change
| * have a unique domain-separated hash (`version || features || commitment|| RangeProof Hash || Sender Offset Public Key || Metadata signature || script || covenant || encrypted_data || minimum value promise`) with the domain (`transaction_output`) | |
| * have a unique domain-separated hash (`version || features || commitment || RangeProof Hash || Sender Offset Public Key || Metadata signature || script || covenant || encrypted_data || minimum value promise`) with the domain (`transaction_output`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates and fixes to rfcs, part 1 of many,
This includes a new about explaing the process