Skip to content

Refactor update analysis - #66

Open
PizieDust wants to merge 3 commits into
tarides:mainfrom
PizieDust:refactor
Open

PizieDust wants to merge 3 commits into
tarides:mainfrom
PizieDust:refactor

Conversation

@PizieDust

@PizieDust PizieDust commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

This PR performs a minor cosmetic refactoring to reduce code lines.
Mainly changing a match to use Result.fold

cc @pitag-ha @voodoos @lyrm

@pitag-ha pitag-ha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together with @lyrm .

The first refactor looks good! For the second one, we have a question.

Comment thread lib/backend.ml Resolved
@pitag-ha pitag-ha mentioned this pull request Oct 7, 2026

@voodoos voodoos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

Comment thread lib/backend.ml Resolved
@PizieDust
PizieDust requested a review from voodoos October 29, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants