Repository navigation
fix: link libexecinfo on BSDs; mark riscv64 unavailable - #21
Merged
Merged
Conversation
Two opam-repository CI portability fixes (ocaml/opam-repository#30964), separate from the vendored-build -j cap already in 0.2.3: - FreeBSD: the vendored build compiled and installed, but the test executables failed to link with `undefined symbol: backtrace` / `backtrace_symbols`. Those symbols are in libc on glibc and in libSystem on macOS, but in a separate libexecinfo on the BSDs. Add `-lexecinfo` to the vendored link flags on FreeBSD/OpenBSD/NetBSD/ DragonFly. - riscv64: the property-test executable crashes at runtime on debian-13/riscv64 (the build succeeds and the alcotest suites pass) - a distinct ABI issue from the build. Mark the package unavailable on riscv64 until it is diagnosed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two portability fixes surfaced by opam-repository CI on #30964 (
xgboost.0.2.3), independent of the-j 6vendored-CMake cap already shipped in 0.2.3.FreeBSD — link
libexecinfoThe vendored build compiles and installs on FreeBSD 15.1, but the test executables fail at link:
backtrace/backtrace_symbols(used by XGBoost's bundleddmlclogging) are in libc on glibc and in libSystem on macOS, but on the BSDs they live in a separatelibexecinfo. The vendored link flags now add-lexecinfoon FreeBSD/OpenBSD/NetBSD/DragonFly (libexecinfois in FreeBSD base — no depext needed). The package stays available there.riscv64 — mark unavailable
On
debian-13,riscv64(system libxgboost), the build succeeds and the alcotest suites pass, but the qcheck property executable crashes at runtime (prints its banner, then dies with no results). This is a separate ABI issue from the build/parallelism one. Exclude the arch (available: ... & arch != "riscv64") until the crash is diagnosed.Follow-up
After merge: cut a new release and refresh ocaml/opam-repository#30964 via opam-publish so CI runs against these fixes.
🤖 Generated with Claude Code