fix: resolve analyzer findings surfaced by the RatScanner gate

RatEye/Config/Config.cs

@@ -10,7 +10,7 @@ public partial class Config
         /// <summary>
         /// Log debug data
         /// </summary>
-        public static bool LogDebug = false;
+        public static bool LogDebug { get; set; } = false;
 
         /// <summary>
         /// Path configuration object

RatEye/Config/Path.cs

@@ -80,12 +80,12 @@ public static string TesseractLibSearchPath
             /// <summary>
             /// Path of the debug folder which is used to store debug information
             /// </summary>
-            public static string Debug = Combine(BaseDir, "Debug");
+            public static string Debug { get; set; } = Combine(BaseDir, "Debug");
 
             /// <summary>
             /// Path of the log file
             /// </summary>
-            public static string LogFile = Combine(BaseDir, "Log.txt");
+            public static string LogFile { get; set; } = Combine(BaseDir, "Log.txt");
 
             /// <summary>
             /// Create a new path config instance

RatEye/Config/Processing.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using RatStash;
 
 namespace RatEye
@@ -84,8 +85,8 @@ internal string GetHash()
                 {
                     UseCache.ToString(),
                     Language.ToString(),
-                    Scale.ToString(),
-                    BaseSlotSize.ToString(),
+                    Scale.ToString(CultureInfo.InvariantCulture),
+                    BaseSlotSize.ToString(CultureInfo.InvariantCulture),
                     IconConfig.GetHash(),
                     InspectionConfig.GetHash(),
                     InventoryConfig.GetHash(),

RatEye/Config/Processing/Inventory.cs

@@ -1,4 +1,5 @@
-using OpenCvSharp;
+using System.Globalization;
+using OpenCvSharp;
 
 namespace RatEye
 {
@@ -57,7 +58,7 @@ internal string GetHash()
                     var components = new string[]
                     {
                         GridColor.ToString(),
-                        BackgroundAlpha.ToString(),
+                        BackgroundAlpha.ToString(CultureInfo.InvariantCulture),
                         MinGridColor.ToString(),
                         MaxGridColor.ToString(),
                         MinHighlightingColor.ToString(),

RatEye/Extensions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Drawing;
 using System.Drawing.Imaging;
 using System.Linq;
@@ -357,7 +358,7 @@ public static string SHA256Hash(this string value)
             var buffer = Encoding.UTF8.GetBytes(value);
             using var sha256 = SHA256.Create();
             var hash = sha256.ComputeHash(buffer);
-            return string.Concat(hash.Select(x => x.ToString("X2")));
+            return string.Concat(hash.Select(x => x.ToString("X2", CultureInfo.InvariantCulture)));
         }
 
         /// <summary>

RatEye/IconManager.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Drawing;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Security.Cryptography;
@@ -442,13 +443,13 @@ private static string GetFileContentHash(string path)
                 FileShare.ReadWrite | FileShare.Delete
             );
             using SHA256 sha256 = SHA256.Create();
-            return string.Concat(sha256.ComputeHash(stream).Select(value => value.ToString("X2")));
+            return string.Concat(sha256.ComputeHash(stream).Select(value => value.ToString("X2", CultureInfo.InvariantCulture)));
         }
 
         private static string GetContentHash(byte[] content)
         {
             using SHA256 sha256 = SHA256.Create();
-            return string.Concat(sha256.ComputeHash(content).Select(value => value.ToString("X2")));
+            return string.Concat(sha256.ComputeHash(content).Select(value => value.ToString("X2", CultureInfo.InvariantCulture)));
         }
 
         private Dictionary<Vector2, Dictionary<string, Mat>> LoadNewIcons(
@@ -1011,7 +1012,7 @@ private string GetIconKey(string iconPath) =>
         /// <returns>The matching item</returns>
         internal Item GetItem(string iconKey)
         {
-            if (iconKey.StartsWith(_config.PathConfig.StaticIcons))
+            if (iconKey.StartsWith(_config.PathConfig.StaticIcons, StringComparison.Ordinal))
             {
                 _staticCorrelationDataLock.EnterReadLock();
                 try

RatEye/Processing/Icon.cs

@@ -189,7 +189,7 @@ private void SatisfyState(State targetState)
 							OCR();
 						break;
 					default:
-						throw new Exception("Cannot satisfy unknown state.");
+						throw new InvalidOperationException("Cannot satisfy unknown state.");
 				}
 
 				_currentState++;
@@ -220,7 +220,7 @@ private void TemplateMatch(bool rotated = false)
 
 			if (!IconConfig.UseStaticIcons)
 			{
-				throw new Exception(
+				throw new InvalidOperationException(
 					"No icons for template matching can be used."
 						+ nameof(IconConfig.UseStaticIcons)
 						+ " is false."

RatEye/Processing/Inspection.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Drawing;
 using System.IO;
-using System.Linq;
 using OpenCvSharp;
 using OpenCvSharp.Extensions;
 using RatStash;
@@ -169,7 +168,7 @@ private void SatisfyState(State targetState)
 						ScanTitle();
 						break;
 					default:
-						throw new Exception("Cannot satisfy unknown state.");
+						throw new InvalidOperationException("Cannot satisfy unknown state.");
 				}
 
 				_currentState++;

RatEye/Processing/Inventory.cs

@@ -74,7 +74,7 @@ private void SatisfyState(State targetState)
 						ParseInventoryGrid();
 						break;
 					default:
-						throw new Exception("Cannot satisfy unknown state.");
+						throw new InvalidOperationException("Cannot satisfy unknown state.");
 				}
 
 				_currentState++;

RatEye/Processing/MultiInspection.cs

@@ -16,7 +16,6 @@ public class MultiInspection
 		private readonly Config _config;
 		private readonly Bitmap _image;
 
-		private Config.Path PathConfig => _config.PathConfig;
 		private Config.Processing ProcessingConfig => _config.ProcessingConfig;
 		private Config.Processing.Inspection InspectionConfig => ProcessingConfig.InspectionConfig;
 
@@ -75,7 +74,7 @@ private void SatisfyState(State targetState)
 						SearchMarker();
 						break;
 					default:
-						throw new Exception("Cannot satisfy unknown state.");
+						throw new InvalidOperationException("Cannot satisfy unknown state.");
 				}
 
 				_currentState++;

RatEye/ProcessingTimings.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Diagnostics;

RatEye/Properties/AssemblyInfo.cs

@@ -0,0 +1,4 @@
+using System.Resources;
+
+// CA1824: the embedded resources in this assembly are English (RatEye.Properties).
+[assembly: NeutralResourcesLanguage("en")]

RatEye/RatEyeEngine.cs

@@ -111,7 +111,11 @@ private void ThrowIfDisposed()
 		/// its icon manager, Tesseract engines, and inspection marker. Complete
 		/// all work on returned processing objects before disposing the engine.
 		/// </remarks>
-		public void Dispose() => DisposeCore(throwOnFailure: false);
+		public void Dispose()
+		{
+			GC.SuppressFinalize(this);
+			DisposeCore(throwOnFailure: false);
+		}
 
 		/// <summary>
 		/// Releases processing resources and throws if any cleanup operation fails.
@@ -120,7 +124,13 @@ private void ThrowIfDisposed()
 		/// Prefer normal <see cref="Dispose"/> for using blocks so a cleanup failure cannot mask
 		/// an active processing exception. Call this method when explicit teardown must fail fast.
 		/// </remarks>
-		public void DisposeStrict() => DisposeCore(throwOnFailure: true);
+		public void DisposeStrict()
+		{
+			// CA1816: SuppressFinalize belongs only in the IDisposable.Dispose
+			// implementation; the finalizer is harmless after DisposeStrict because
+			// DisposeCore is idempotent via _disposed.
+			DisposeCore(throwOnFailure: true);
+		}
 
 		/// <summary>
 		/// Gets the aggregate failure from the cleanup attempt, if any.
@@ -194,7 +204,6 @@ private void DisposeCore(bool throwOnFailure)
 					Config.ProcessingConfig.InspectionConfig.DisposeMarker,
 					cleanupErrors
 				);
-				GC.SuppressFinalize(this);
 
 				if (cleanupErrors.Count > 0)
 				{

RatEye/Vector2.cs

@@ -1,6 +1,4 @@
-using System;
-
-namespace RatEye
+namespace RatEye
 {
     /// <summary>
     /// A 2D <see cref="int"/> vector