Skip to content

feat: base node #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
younocode merged 69 commits into from
Dec 9, 2025
Merged

feat: base node #2168

younocode merged 69 commits into from
Dec 9, 2025

Conversation

@younocode
Copy link
Contributor

@younocode younocode commented Nov 25, 2025

No description provided.

@younocode younocode force-pushed the feat/base-node branch 2 times, most recently from 006c7d3 to 822896e Compare November 26, 2025 14:39
@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20065394908

Details

  • 1916 of 2478 (77.32%) changed or added relevant lines in 35 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feat/base-node at 71.858%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/setting/open-api/setting-open-api.controller.ts 0 1 0.0%
apps/nestjs-backend/src/features/base-node/base-node.permission.helper.ts 65 67 97.01%
apps/nestjs-backend/src/features/base-node/helper.ts 36 38 94.74%
apps/nestjs-backend/src/features/notification/notification.service.ts 1 3 33.33%
apps/nestjs-backend/src/event-emitter/events/base/folder/base.folder.event.ts 33 41 80.49%
apps/nestjs-backend/src/features/base-node/base-node.controller.ts 90 98 91.84%
apps/nestjs-backend/src/features/table/open-api/table-open-api.service.ts 6 14 42.86%
apps/nestjs-backend/src/features/table/open-api/table.pipe.helper.ts 13 22 59.09%
apps/nestjs-backend/src/event-emitter/interceptor/event.Interceptor.ts 20 30 66.67%
apps/nestjs-backend/src/features/base/base-import.service.ts 129 139 92.81%
Totals Coverage Status
Change from base Build 20057878114: 71.9%
Covered Lines: 57741
Relevant Lines: 80354
💛 - Coveralls

@younocode younocode added the preview This issue is already ready for preview label Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

6 similar comments
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@younocode younocode requested a review from Copilot December 1, 2025 09:00
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a hierarchical base node system to organize tables, dashboards, workflows, and apps within folders. It adds tree navigation capabilities using the @headless-tree library, implements comprehensive CRUD APIs for node management, and includes database models with appropriate migrations.

Key Changes

  • Adds @headless-tree/core and @headless-tree/react (v1.5.1) for tree functionality
  • Implements BaseNode and BaseNodeFolder database models with self-referential relationships
  • Creates comprehensive base node API endpoints (CRUD, move, duplicate operations)
  • Adds Tree UI component with drag-and-drop support and folder depth validation
  • Updates pin functionality to support new resource types (Dashboard, Workflow, App)

Reviewed changes

Copilot reviewed 119 out of 120 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pnpm-lock.yaml, packages/ui-lib/package.json Adds @headless-tree dependencies v1.5.1
packages/db-main-prisma/prisma/*.prisma Defines BaseNode and BaseNodeFolder models with constraints
packages/openapi/src/base-node/* Implements base node API schemas and routes
packages/ui-lib/src/shadcn/ui/tree.tsx New Tree UI component with item management
apps/nextjs-app/src/features/app/blocks/base/base-node/* React hooks and context for node management
apps/nestjs-backend/test/base-node*.e2e-spec.ts Comprehensive e2e tests for node operations
packages/openapi/src/pin/types.ts Extends PinType enum with Dashboard, Workflow, App
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

2 similar comments
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

2 similar comments
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@younocode
feat: add workflow state render
5036f3b
@younocode
fix: sync dataLoader returned undefined error
5566960
@younocode
refactor: update styling in BaseNodeTree for improved layout and cons…
a924a08 
…istency
@younocode
refactor: remove setEditingNodeId when create and duplicate
18f53d8
@younocode
refactor: extract table creation logic for improved readability
26fa600
@younocode
refactor: update dropdown menu width and enhance delete confirmation …
4c5cf9b 
…title with resource type
@younocode
fix: common noun i18n
f72af6c
@younocode
feat: introduce useBaseNodeContext hook for improved context manageme…
b63bb50 
…nt in BaseNode components
@younocode
refactor: update useBaseNode for enhanced context management
00e1356
@younocode
refactor: enhance BaseNodeTree component with edit mode support and i…
01926e3 
…mproved local storage handling
@younocode
feat: add onUpdateError callback to useBaseNodeCrud and BaseNodeTree …
0b72e80 
…for improved error handling
@younocode
refactor: improved UI consistency
d6c65ec
@younocode
refactor: improve menu invalidation
1a9406c
@younocode
refactor: remove permanent delete functionality from UI components
2c90905
@younocode
refactor: permission handling by consolidating base node actions
1956693
@younocode
feat: implement base node event handling with create, update, and del…
950bfa1 
…ete events
@younocode
refactor: base node event
354d5d8
@younocode
refactor: remove table iist in ssr
410397b
@younocode
feat: enhance BaseNodeTree with highlight
877b260
@younocode
feat: update BaseNodeTree to expand parent nodes on selection
2fe5755
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2168.sealoshzh.site

@younocode younocode merged commit 8deafda into develop Dec 9, 2025
32 of 37 checks passed
@younocode younocode deleted the feat/base-node branch December 9, 2025 14:07
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🧹 Preview Environment Cleanup

  • PR feat: base node #2168 has been Merged
  • Preview environment has been deleted
  • Cleanup time: 2025-12-09T14:08:13.089Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@boris-w boris-w boris-w approved these changes

@tea-artist tea-artist Awaiting requested review from tea-artist

Assignees

No one assigned

Labels

preview This issue is already ready for preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@younocode @coveralls @boris-w