Skip to content

Fix for multi select custom fields when saving #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chucheen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for multi select custom fields when saving #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c7ca0
Fix for multi select custom fields when saving
Chucheen Sep 10, 2016
3bc5982
Using constant for multiselect type
Chucheen Sep 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/amorail/entity/params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
module Amorail # :nodoc: all

MULTISELECT_FIELD_TYPE = '5'

class Entity
def params
data = {}
Expand All @@ -17,11 +20,10 @@ def custom_fields
props = properties.send(self.class.amo_name)

custom_fields = []

self.class.properties.each do |k, v|
self.class.properties.each do |k, value|
prop_id = props.send(k).id
prop_val = { value: send(k) }.merge(v)
custom_fields << { id: prop_id, values: [prop_val] }
prop_val = props.send(k)['type_id'] == MULTISELECT_FIELD_TYPE ? [send(k)] : { value: send(k) }.merge(value)
custom_fields << { id: prop_id, values: [prop_val].flatten }
end

custom_fields
Expand All @@ -41,7 +43,10 @@ def create_params(method)

def normalize_custom_fields(val)
val.reject do |field|
field[:values].all? { |item| !item[:value] }
next if field[:values].instance_of? Array
field[:values].all? { |item|
!item[:value]
}
end
end

Expand Down