Skip to content

Expand click_on beyond just an alias of click_link_or_button#2182

Open
twalpole wants to merge 2 commits into
masterfrom
click_on
Open

Expand click_on beyond just an alias of click_link_or_button#2182
twalpole wants to merge 2 commits into
masterfrom
click_on

Conversation

@twalpole

@twalpole twalpole commented May 1, 2019

Copy link
Copy Markdown
Member

This changes click_on from just an alias of click_link_or_button into a shortcut for find(...).click, by allowing it to accept a selector type. It defaults to a selector type of link_or_button to retain previous behavior as the default. I'm not 100% sold on this being a good idea yet.

@coveralls

coveralls commented May 1, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6119

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 98.671%

Totals Coverage Status
Change from base Build 6116: 0.009%
Covered Lines: 13067
Relevant Lines: 13243

💛 - Coveralls

@twalpole twalpole force-pushed the click_on branch 4 times, most recently from dc7b23f to c026f0f Compare May 8, 2019 01:49
@twalpole twalpole force-pushed the click_on branch 4 times, most recently from fa3211b to d0cd651 Compare May 18, 2019 16:50
@twalpole twalpole force-pushed the click_on branch 2 times, most recently from 155e758 to 11d9811 Compare May 29, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants