Some fixes for multiple content assign to single user#10
Open
sanjivani1812 wants to merge 4 commits intotechjoomla:release-1.1.0from
Open
Some fixes for multiple content assign to single user#10sanjivani1812 wants to merge 4 commits intotechjoomla:release-1.1.0from
sanjivani1812 wants to merge 4 commits intotechjoomla:release-1.1.0from
Conversation
coolbung
reviewed
Oct 19, 2018
coolbung
reviewed
Oct 19, 2018
src/administrator/includes/rbacl.php
Outdated
| * | ||
| * @since 1.6 | ||
| */ | ||
| public function getAuthorizedActions($agencyId = null, $userId = null, $roleId = null) |
Member
There was a problem hiding this comment.
Why are there hardcoded references to com_multiagency ?
Contributor
Author
There was a problem hiding this comment.
Changed the variable name.
thite-amol
reviewed
Oct 19, 2018
| if (!empty($userRoleId)) | ||
| { | ||
| $db = JFactory::getDBO(); | ||
| $subInQuery = $db->getQuery(true); |
Contributor
There was a problem hiding this comment.
@sanjivani1812 Move the DB operations in the model
Contributor
Author
There was a problem hiding this comment.
@thite-amol - getRoleByUser function having DB operation so I put there. Can please suggest a model name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this file, I have added array_intersect in check function, because when multiple client_id assign to a single user then only first client_id check. need to check all roles across the system.
In this file two changes needed
2.a) In getTable table add table file
2.b) In getAssociatedContentRole function contentId variable make optional and changed query result to get all role column result.