Conversation
…ations Co-authored-by: gpaoloni <15805319+gpaoloni@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests to filterSelectionState
chore: add unit tests to filterSelectionState (plugin-hrm-form/src/states/resources/filterSelectionState/)
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit test coverage for the KHP and USCH
filterSelectionStateimplementations, which drive reference data loading and search filter state management for their respective resource configurations.New test files
src/___tests__/states/resources/filterSelectionState/khp.test.ts— 28 testssrc/___tests__/states/resources/filterSelectionState/usch.test.ts— 30 testsCoverage per function
referenceLocationsInitialState— shape assertion for both implementations.loadReferenceActionFunction— mocksgetReferenceAttributeList(KHP) /getDistinctStringAttributes(USCH); asserts correct API call args, option deduplication, sort order, andinfo.name ?? valuelabel fallback.handleLoadReferenceLocationsAsyncActionFulfilled— per list type (Provinces/Regions/Cities for KHP; Country/Provinces/Cities for USCH), verifiesreferenceLocationsupdate and cascadingfilterOptionsrecomputation. Key edge cases:validatedFilterSelectionsdirectly)"United States"at index > 0 → moved to head and auto-selected; at index 0 → not auto-selected (containsDefaultOptionrequiresindex > 0); absent → no auto-selection{ ...defaultFilterSelection, ...validatedFilterSelections }, where absent keys do not overridehandlerUpdateSearchFormAction— verifies cascading filter updates (province → region → city for KHP; country → province → city for USCH), invalidation of downstream selections when parent changes, and age-range filter mutual constraint logic (KHP).Checklist
Other Related Issues
None
Verification steps
Run the new test suites:
Expected: 58 tests pass across 2 suites.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.