Added TextBlock with assembly path in tab comparison#52
Open
salem84 wants to merge 1 commit intotelerik:masterfrom
Open
Added TextBlock with assembly path in tab comparison#52salem84 wants to merge 1 commit intotelerik:masterfrom
salem84 wants to merge 1 commit intotelerik:masterfrom
Conversation
atdimitrov
suggested changes
Jan 2, 2019
Contributor
There was a problem hiding this comment.
This does not work well with paths longer than the width of the source code viewer - the text is just cut off. Since good solution to this would cost a lot of time I would suggest adding a tooltip when hovered and add ellipsis if it does not fit. Wrapping to multiple lines is not a solution here because:
- it can take a lot of screen space if the application is resized to very narrow window
- both paths should be equal in height, which can be somewhat difficult to achieve. This is needed because the source code should match line by line.
| ScrollingLimit="{Binding ScrollingLimit, Mode=TwoWay}" | ||
| FontSize="{Binding FontSize, Mode=TwoWay}" /> | ||
| <StackPanel Grid.Column="1"> | ||
| <TextBlock Text="{Binding LeftSourceCode.AssemblyPath}" Background="#EFEFEF" Margin="15,5,0,0" FontStyle="Italic"/> |
Contributor
There was a problem hiding this comment.
The design part looks a bit strange and asymmetrical. I would suggest replacing the margin with Padding="5". It should look a lot cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #22