Repository navigation
fix: check required resource fields of a response in Python and .NET - #279
Merged
Merged
Conversation
A response field is always optional, so an empty response built a resource without its identity field.
This was referenced Oct 23, 2026
tconley1428
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR checks a resource's required field in a response before an operation builds the resource. Python raises
RuntimeErrorand .NET throwsInvalidOperationException. TypeScript already checks it.The fix is in the second commit, 6ebfe8bc. The first commit makes the
stream-servicesample'screate-streamreturn thestreamresource, with the output on main.Why?
A proto response field is always optional. On main, an empty response builds a
Streamwith no ref, and the Python sample doesn't type-check.How did you test it?
The Python and .NET goldens show the check in
create-stream.