Repository navigation
test: add a status enum to the stream-service create result - #282
Merged
tconley1428 merged 1 commit intoOct 26, 2026
Merged
tconley1428 merged 1 commit into
tconley1428 merged 1 commit into
Conversation
moetemp
force-pushed
the
moe/up/result-record-holds-resource-2
branch
from
October 26, 2026 19:56
f702dac to
ffe6ab6
Compare
The stream service answers a create with the stream's status. Today's compiler plans the proto-backed enum, so the sample needs no compiler change.
moetemp
force-pushed
the
moe/up/create-stream-status
branch
from
October 26, 2026 20:05
1cd528d to
1b615ca
Compare
tconley1428
approved these changes
Oct 26, 2026
tconley1428
merged commit Oct 26, 2026
9a292c5
into
moe/up/result-record-holds-resource-2
3 checks passed
tconley1428
pushed a commit
that referenced
this pull request
Oct 26, 2026
* Made the stream-service create return a record that holds the stream. Today's compiler can't generate this shape, so this commit has only the WIT. * Let a proto-backed result record hold a resource in an own<T> field. A create often answers with a handle and with facts about the create, such as whether it made a new object. An own<T> result alone dropped those facts. * Regenerated the workflow-handle .NET models, which main's validate flags. * Renamed the workflow-run sample to proto-record-with-resource. The name now says what the sample checks. The WIT keeps its workflow run domain. * Added a proto-backed status enum to the stream-service create result. (#282) The stream service answers a create with the stream's status. Today's compiler plans the proto-backed enum, so the sample needs no compiler change. * Dropped the extra sample, since stream-service covers a holder record. Its create-stream returns a proto-backed record that holds the stream, next to created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds a proto-backed
stream-statusenum to thestream-servicesample, and astatusfield tocreate-stream-result, as the stream service has. The sample proto, its descriptor set and its bindings are rebuilt with the README commands.Needs #280.
Why?
The sample follows the stream service's create result, which has a status. Proto-backed enums plan on main since #262.
How did you test it?
The goldens. Each target gets a
StreamStatusenum, andcreate-streamcopiesstatusinto the result.