Skip to content

Fix .NET variant warnings and unused model imports - #287

Merged
tconley1428 merged 1 commit into
mainfrom
amazzeo/dotnet-model-fixes
Oct 26, 2026
Merged

tconley1428 merged 1 commit into
mainfrom
amazzeo/dotnet-model-fixes

Conversation

@VegetarianOrc

@VegetarianOrc VegetarianOrc commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Propagate experimental XML remarks to nested variant case records, including generic notification result cases.
  • Omit the unused Temporalio.Converters import from model files while retaining it in service files that use ISerializationContext.
  • Add regression coverage, regenerate .NET samples, and update the authoring guide and changelog.

Fixes #283
Fixes #284

Validation

  • Full cargo validate passed: Rust, Python, TypeScript, Go, Java, .NET, Markdown, and cross-language JSON Schema conformance.

@VegetarianOrc
VegetarianOrc requested a review from a team as a code owner October 24, 2026 00:04
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tconley1428
tconley1428 merged commit a33c897 into main Oct 26, 2026
5 checks passed
@tconley1428
tconley1428 deleted the amazzeo/dotnet-model-fixes branch October 26, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: omit unused converter namespace import .NET: propagate experimental remarks to nested variant case types

4 participants