Repository navigation
Use System.CommandLine for sample and test runner argument parsing - #243
Open
jmaeagle99 wants to merge 1 commit into
Open
jmaeagle99 wants to merge 1 commit into
jmaeagle99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Samples and the standalone test runner now parse their arguments with System.CommandLine instead of hand-rolled
argsswitches. Command names are unchanged, so the README instructions still work.Behavior differences:
--helpworks everywhere, and it, like argument errors, no longer needs a running server.Console.CancelKeyPresshandler.--workflow/--start-workflow/--query-workflowoptions its README already documented.gen-client-certsnow accepts--file-prefixand the CA options, which were previously never registered.Why?
--helpand inconsistent errors. A mistyped command produced a stack trace, often after connecting to the server.--workflow/--start-workflowoptions that the code silently ignored.Checklist
Closes Use System.CommandLine for arg parsing #239
Any docs updates needed? No