Repository navigation
feat: retrieve external storage references on inbound payloads - #996
Open
jmaeagle99 wants to merge 1 commit into
Open
jmaeagle99 wants to merge 1 commit into
jmaeagle99 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Inbound payloads now have their external storage references resolved before decoding. When a reference is present but no external storage is configured, it is rejected with
TMPRL1105rather than silently passed through to the codec and payload converter.DataConvertercarries an internalExternalStoragethat is propagated onto context-scoped converters.ExternalStorageRunner.Createreturns a runner that retrieves references when storage is configured, and one that rejects them withTMPRL1105when it is not.ToSingleValueAsync,ToExceptionAsync), which covers deferred paths such as memos, raw values, and failures.Testing
ConverterExtensionsTestscovers decode funnels for reject-when-unconfigured (TMPRL1105) and retrieve-when-configured (the retrieved value surfaces through the decoded value and the reconstructed exception's details).ExternalStorageRunnerTestscovers theCreatefactory: the unconfigured runner rejects references and passes plain payloads through; the configured runner retrieves.DataConverterTestscoversExternalStoragepropagation acrossWithSerializationContext.dotnet test --filter Converters,dotnet format(whitespace + style) clean.