chore(sdk): mark remaining Options types as non_exhaustive - #1450
Merged
Conversation
chris-olszewski
force-pushed
the
olszewski/non_exhaustive
branch
from
August 5, 2026 13:08
89d9281 to
b7bbd59
Compare
chris-olszewski
force-pushed
the
olszewski/non_exhaustive
branch
from
August 5, 2026 13:48
c8836e2 to
bfc4876
Compare
chris-olszewski
commented
Aug 5, 2026
| } | ||
|
|
||
| /// Options for Nexus Operations | ||
| #[derive(Default, Debug, Clone)] |
Member
Author
There was a problem hiding this comment.
Removing Default here as I think that was compensating for the lack of builder. There isn't really a valid "default" here since empty endpoint/service/operation isn't sensible.
chris-olszewski
marked this pull request as ready for review
August 5, 2026 13:50
Sushisource
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Go through remaining public
Optionsstructs and ensure they all:#[non_exhaustive]bonto provide a builderPartialEqimplementations where applicableEach commit is reviewable on its own.
Why?
Without the
non_exhaustiveattribute, any expansion to these options would be a breaking change.Checklist
Closes N/A
How was this tested:
👀, did add unit tests that
T::default() == T::builder().build()to ensure those don't diverge.Any docs updates needed?
N/A