extstore/surface exstore errors in client - #2260
Open
cconstable wants to merge 4 commits into
Open
Conversation
cconstable
commented
Jul 24, 2026
…rom extstore runner.
cconstable
force-pushed
the
extstore/surface-exstore-errors-in-client
branch
from
July 27, 2026 15:30
ea9589f to
051eed6
Compare
THardy98
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Previously, surfacing external storage errors from client logic meant that callers would see the new extstore error type which could break compatibility. This PR patches the error types that are thrown to include a
causewhere upstream errors can be put. This means we can move the extstore calls back inside the try/catch blocks, catch them meaningfully, and still throw consistent error types.Checklist