Mark integration tests that require a local server - #2281
Draft
THardy98 wants to merge 2 commits into
Draft
Conversation
THardy98
added
the
skip-changelog
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the normal AVA suite through envconfig needs a TypeScript equivalent of Python's
requires_local_servermarker. Without one, tests that depend on dev-server configuration either fail against Cloud or silently launch local infrastructure and make Cloud coverage ambiguous.This change adds an internal
requiresLocalServer(reason, test)adapter and arequiresLocalServeroption to the shared integration-test factory. When envconfig selects the test server, annotated tests and hooks are registered as skipped, so suite setup cannot launch a local server; with the gate disabled, the original AVA function is returned unchanged. The shared integration helper also rejects local server options in envconfig mode rather than silently ignoring them.Focused coverage verifies local pass-through, Cloud skips for tests and hooks, mandatory reasons, and rejection of server-only options. The seven combined Cloud-foundation AVA tests pass. The package TypeScript build reaches only the two pre-existing
ActivityExecutionStatus.PAUSEDerrors on current main.Part of temporalio/features#851.