Surface Nexus endpoint cleanup failures - #2283
Draft
THardy98 wants to merge 1 commit into
Draft
Conversation
THardy98
added
the
skip-changelog
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nexus test helper currently catches and discards every endpoint-deletion error during AVA teardown. That is mostly hidden by ephemeral dev servers, but it would leak endpoints on a persistent server when deletion fails because of permissions, transport errors, or version conflicts.
This change makes teardown fail for every deletion error except
NOT_FOUND, which preserves idempotency for tests that explicitly deleted the endpoint before their registered teardown runs. No Nexus test is enabled against Cloud by this PR; it establishes the cleanup guarantee required before privileged Cloud coverage can be considered.Focused AVA coverage verifies both propagated deletion failures and tolerated already-deleted endpoints. Prettier and ESLint pass. The package TypeScript build reaches only the unrelated
ActivityExecutionStatus.PAUSEDerrors present in this worktree's advanced sdk-core submodule.Part of temporalio/features#851.