Repository navigation
AgentCore Support (1/3) - Add AgentCore provider references - #25
justinschoeff wants to merge 3 commits into
Conversation
starfleeth
left a comment
starfleeth
left a comment
There was a problem hiding this comment.
Could you trim the authoring and local-environment narration from this description? In particular, please remove the /tmp/... paths, raw local validation transcript, “cmp passes,” “None comes from a test run,” and the discussion of which branch should fix the existing validator failure. A concise result-oriented section would be more durable: canonical template provenance, link/citation checks passed, and one known base-branch validator issue linked to its tracking item.
| samples-python@d67795f: bedrock_agentcore/strands_agent/ | ||
| --> | ||
|
|
||
| Temporal has no AgentCore troubleshooting page. This guide uses only the gotchas documented in the sources above and the shared [Worker Controller Instance (WCI)](../wci.md) inspection flow. If a symptom is not covered here, gather the evidence below and report it to the user. Do not attach an undocumented explanation to it. |
There was a problem hiding this comment.
Could you remove the explanation of how this guide was authored (“uses only the gotchas documented in the sources above”) and state the durable operating rule directly? For example: “Use the WCI inspection flow below. For symptoms not covered here, gather the listed evidence and escalate without speculating about the cause.”
|
|
||
| ### Temporal Cloud | ||
|
|
||
| Template: [`assets/temporal-cloud-serverless-worker-agentcore-role.yaml`](../../assets/temporal-cloud-serverless-worker-agentcore-role.yaml). It is vendored unchanged from Temporal's S3 copy. The trust policy lists Temporal Cloud's principals and requires `sts:ExternalId`. <!-- assets/temporal-cloud-serverless-worker-agentcore-role.yaml:45-68 --> |
There was a problem hiding this comment.
“Vendored unchanged” is a point-in-time authoring claim that becomes inaccurate after any subsequent edit. Please remove it or replace it with stable provenance that identifies the canonical source and revision without asserting that the files remain identical.
|
|
||
| ## Resource inventory | ||
|
|
||
| Record each resource as you create it: the AgentCore project directory and target, the Runtime name and ARN, the endpoint name and ARN, the CloudFormation stack and role ARN, the External ID, the Region, and the deployment name and Build ID. Hand the inventory to the user at the end. AgentCore teardown commands are not covered by this skill's sources, so before you delete any AgentCore resource, ask the user how they want to remove it. Never unset or delete a Temporal version while Pinned Workflows still need it (see `versioning.md`). |
There was a problem hiding this comment.
Could you remove the source-coverage narration (“not covered by this skill’s sources”) and state the safety rule directly? For example: “Do not delete AgentCore resources automatically; ask the user which supported removal method they want to use.”
| docs/production-deployment/worker-deployments/serverless-workers/agentcore-self-hosted-setup.mdx | ||
| docs/guides/durable-agent-on-agentcore.mdx | ||
| aws: https://docs.aws.amazon.com/bedrock-agentcore/latest/devguide/runtime-lifecycle-settings.html | ||
| samples-python@d67795f: bedrock_agentcore/strands_agent/ |
There was a problem hiding this comment.
The exact sample commit appears throughout the new reference files and reads as authoring-time “checked against this version” metadata. If this pin is an intentional compatibility baseline, please document how and when it should be updated. Otherwise, please use stable source paths and keep checkout-specific validation details in the PR rather than the shipped skill.
Add references/aws-agentcore/ (constraints, setup, iam, versioning, diagnostics, observability, self-hosted) and the Cloud and self-hosted invocation-role CloudFormation templates, following the per-provider layout used for Lambda and Cloud Run. Setup uses the AgentCore CLI: CodeZip for Python and the Container build (built in AWS CodeBuild, no local Docker) for TypeScript. It includes the Secrets Manager API-key hand-off, named endpoints, READY checks through the AWS API, endpoint log groups, and a created/reused inventory with teardown. Corrections from the end-to-end Python and TypeScript validation deploys are folded in.
1feb04e to
a270af9
Compare
Deleting a Runtime and its CDK stack leaves one log group per endpoint, including DEFAULT. The validation teardown found them still present, so teardown now removes them.
The TypeScript teardown also left the CodeBuild and build-trigger Lambda log groups after the CDK stack was deleted. Name both so teardown removes them.
AgentCore Support (1/3). Based on
main(after #24 and #29). (2/3) is #26, and (3/3) is #27.This PR adds Amazon Bedrock AgentCore Runtime (
aws-agentcore) as a Serverless Worker provider. It follows thereferences/aws-lambda/andreferences/gcp-cloud-run/layout and only changes files underreferences/aws-agentcore/andassets/. The SDK guides come in #26, and SKILL.md, README and concepts.md are integrated in #27.The stack was rebuilt from consolidated commits: one commit per PR, built from the final file states. The corrections from the end-to-end validation deploys are folded in. Details are in #27, under "Validation".
What's added
references/aws-agentcore/:constraints.md: covers:setup.md: the AgentCore CLI path, with no local Docker. Python uses CodeZip, and TypeScript uses the Container build, which the CLI builds in AWS CodeBuild. It also covers:aws-targets.json;codeLocation;READYcheck throughget-agent-runtime-endpoint;iam.md: the operator, the Runtime execution role and the invocation role, for Cloud and self-hosted. It covers the API-key lifecycle and adding a Runtime to an existing invocation stack.versioning.md: how WDVs map to Runtime versions and named endpoints, theDEFAULThazard, and rollout and rollback.diagnostics.md: documented gotchas plus the sharedreferences/wci.mdflow.observability.mdself-hosted.md: a full guide for v1.32.0+.assets/temporal-cloud-serverless-worker-agentcore-role.yaml: byte-identical to the S3 template (https://temporal-server-scaled-workers-config.s3.us-west-2.amazonaws.com/cloudformation/temporal-worker-role-agentcore.yaml).assets/temporal-self-hosted-serverless-worker-agentcore-role.yaml: from the docs'static/files/copy (trustsTemporalIamRoleArn).The durable-agent guide is linked, not reproduced. Following #29, the files have no
<!-- -->source tags.Validation
skills-ref validate(agentskills 0.1.1) reports onlydisable-model-invocationas an unexpected frontmatter field.origin/mainhas the same error, so this PR doesn't introduce it.