Modernize some for loops and fix some signed/unsigned issues #4438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
egorpugin
approved these changes
Jul 6, 2025
Contributor
egorpugin
left a comment
egorpugin
left a comment
There was a problem hiding this comment.
Some loops can be further improved with algorithms/ranges, but not insisting on changes
| unsigned s = 0; | ||
| for (s = 0; s < allowed_scripts_->size(); ++s) { | ||
| if ((*allowed_scripts_)[s] == choice_script) { | ||
| for (auto script : *allowed_scripts_) { |
Contributor
There was a problem hiding this comment.
Can be if (std::ranges::find(*allowed_scripts_, choice_script) != allowed_scripts_->end()) ...
| for (const auto &result : results) { | ||
| const auto shape_id = result.shape_id; | ||
| const Shape &shape = shape_table.GetShape(shape_id); | ||
| if (shape.ContainsUnichar(unichar_id)) { |
Contributor
There was a problem hiding this comment.
if (shape_table.GetShape(result.shape_id).ContainsUnichar(unichar_id)) {
also can be put inside std::ranges::find_if()
| for (unsigned r = 0; r < results.size(); ++r) { | ||
| if (results[r].unichar_id == unichar_id) { | ||
| size_t r = 0; | ||
| for (const auto &result : results) { |
Member
Author
Thanks for these suggestions which we can consider in later commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.