Repository navigation
Work around nullability annotations mismatches - #130
Open
brianrourkeboll wants to merge 2 commits into
Open
brianrourkeboll wants to merge 2 commits into
brianrourkeboll wants to merge 2 commits into
Conversation
…torParametersDefault` globally
…ctorParametersDefault` locally
HofmeisterAn
requested changes
Oct 31, 2026
HofmeisterAn
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the issue and the PR. The model classes are generated by tools/specgen, and the bug is there. It only marks pointers and omitempty fields as nullable, but Go also writes nil maps and slices as null.
I think it's better to fix the generator than to turn the switches off in the library, because that would hide the wrong annotations. It would also make them correct at compile time for consumers.
Author
Yes, if we can make the annotations accurate, that would be best. And once they are accurate, we would want to turn these switches on, as in the first commit here (they're off by default for backwards compatibility). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #129.
RespectNullableAnnotationsDefaultandRespectRequiredConstructorParametersDefaultglobally in this repo. (The tests in this repo targeting .NET 9 or higher fail at this commit.)JsonSerializerOptions.RespectNullableAnnotationsandJsonSerializerOptions.RespectRequiredConstructorParametersin code for theJsonSerializerinstance used in this library when targeting .NET 9 or higher, which takes precedence over the global switches in this repo and in any consuming code.If and when the nullable annotations are fixed, the two explicit disablings should be removed.