Skip to content

fix: Align chunk reading behaviour between legacy and modern transports - #131

Merged
HofmeisterAn merged 3 commits into
testcontainers:mainfrom
Hawxy:fixlogpol
Oct 29, 2026
Merged

HofmeisterAn merged 3 commits into
testcontainers:mainfrom
Hawxy:fixlogpol

Conversation

@Hawxy

@Hawxy Hawxy commented Oct 27, 2026

Copy link
Copy Markdown

Some docker daemons answer an empty log endpoint request with Content-Length: 0 and no chunked framing. This results in an exception of IOException: Invalid chunk header encountered: ''. This updates the legacy transport to act in the same way as the modern transport.

@Hawxy

Hawxy commented Oct 27, 2026

Copy link
Copy Markdown
Author

@HofmeisterAn Apologies for the ping, but I don't know if you look at this repo all that often. This causes testcontainer-dotnet crashes on https://namespace.so/ runners with no real workaround at the moment apart from completely disabling Ryuk & rewriting wait behaviours for a number of containers, so it would be nice to get it in.

@HofmeisterAn

Copy link
Copy Markdown
Collaborator

@HofmeisterAn Apologies for the ping, but I don't know if you look at this repo all that often. This causes testcontainer-dotnet crashes on https://namespace.so/ runners with no real workaround at the moment apart from completely disabling Ryuk & rewriting wait behaviours for a number of containers, so it would be nice to get it in.

Yes, I've already seen the PRs, thanks. I'll review the open ones next weekend. I don't have time before then.

@Hawxy

Hawxy commented Oct 27, 2026

Copy link
Copy Markdown
Author

That's fine, thanks!

@HofmeisterAn

Copy link
Copy Markdown
Collaborator

I pushed a few minor changes on top, mostly test cleanup and aligning comments and messages with the repo style. If you're OK with them, I'm happy to merge.

@Hawxy

Hawxy commented Oct 29, 2026

Copy link
Copy Markdown
Author

Looks fine, good to go.

@HofmeisterAn HofmeisterAn changed the title Align chunk reading behaviour between legacy and modern transports fix: Align chunk reading behaviour between legacy and modern transports Oct 29, 2026
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Oct 29, 2026

@HofmeisterAn HofmeisterAn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn
HofmeisterAn merged commit a33a40d into testcontainers:main Oct 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants