Repository navigation
fix: Align chunk reading behaviour between legacy and modern transports - #131
Conversation
|
@HofmeisterAn Apologies for the ping, but I don't know if you look at this repo all that often. This causes testcontainer-dotnet crashes on https://namespace.so/ runners with no real workaround at the moment apart from completely disabling Ryuk & rewriting wait behaviours for a number of containers, so it would be nice to get it in. |
Yes, I've already seen the PRs, thanks. I'll review the open ones next weekend. I don't have time before then. |
|
That's fine, thanks! |
|
I pushed a few minor changes on top, mostly test cleanup and aligning comments and messages with the repo style. If you're OK with them, I'm happy to merge. |
|
Looks fine, good to go. |
Some docker daemons answer an empty log endpoint request with Content-Length: 0 and no chunked framing. This results in an exception of
IOException: Invalid chunk header encountered: ''. This updates the legacy transport to act in the same way as the modern transport.