Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for raising @collinmurd! Looks like testcontainers-java exports a single
Let's do the same here. Also update the module name from oraclefree to oracle ( |
Oracle Free is meant to be the successor to Oracle XE. I haven't found anything that indicates a retirement path from Oracle for XE, but the maintainer for these Oracle images isn't supporting XE anymore. testcontainers-python only exports an |
|
Ah I didn't know, makes sense then, please disregard my last comment |
|
|
||
| const IMAGE = getImage(__dirname); | ||
|
|
||
| describe.sequential("OracleFreeContainer", { timeout: 240_000 }, () => { |
There was a problem hiding this comment.
These can run in parallel
| @@ -0,0 +1 @@ | |||
| FROM gvenzl/oracle-free:slim-faststart No newline at end of file | |||
There was a problem hiding this comment.
Let's pin the image version, gvenzl/oracle-free:23.26.1-slim-faststart is equivalent to current latest. Dependabot will keep it up to date and will catch future breaking changes
Adds a module for Oracle DB support using oracle free. Follows similar implementation to the existing Java and Python modules, which utilize these images