Repository navigation
fix(prefer-to-have-class): support direct elements - #499
Closed
YodHeVauHe wants to merge 1 commit into
Closed
YodHeVauHe wants to merge 1 commit into
YodHeVauHe wants to merge 1 commit into
Conversation
Co-authored-by: ZaSourceCode <YodHeVauHe@users.noreply.github.com>
Collaborator
|
While this looks to address what the OP described (and I think would be my preference at this point), that issue brought up
at this point I'd like more data before committing to a direction, as we've only heard from one user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #490.
prefer-to-have-classreturned early unless the receiver was a Testing Library query, soexpect(document.body).toHaveAttribute('class', …)was never reported. The guard now also allows a direct element.npm test -- --runInBandpassed: 12 suites, 621 tests.npm run lintpassed.