Skip to content

Release a new version with fix, that is already in main branch #1305

Description

@iaroslavshvets

Reproduction example

N/A

Prerequisites

Hi! When test infra is re-used between jsdom env and node e2e(puppeteer/playwright/etc) env, current 14.6.1 breaks every e2e test as there is no window. We don't call user-event in pup, but cjs import itself leads to test crash.

This commit is the fix: 4f882e6

Please, release a new version. Currently we have to use yarn's patch mechanism in every project (there are many), which is not very scalable or convenient and is a dirty hack by nature.

First thing tried to write in discord, but there is no reaction for months :(

Expected behavior

node env not throws

Actual behavior

throws when trying access navigator on window that doesn't exist in e2e node env.

User-event version

14.6.1

Environment

puppeteer tests

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds assessmentThis needs to be looked at by a team member

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions