Random cleanups #306
Merged
Random cleanups #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A return statement signals that a value will be returned, so when the function it is invoked in returns `void` that's potentially confusing. Even though one can do `return function_returning_void();` in a `void` returning function it should be avoided. Much more readable and less confusing to simply call the function and then do a `return;´. Functionally it amounts to the same thing and compilers will generate the same code - this is purely for readability purposes.
Although the names /can/ be different it's just confusing when they are and serves no actual purpose, so make them match.
Both versions are used in the repository, but the "operator=(" form is
much more common than the "operator= (" form, so fix it up so
everything is consistent with the most common version.
No functional difference, just ensuring a consistent style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small cleanups that you may or may not like...