fix: Remove forced 16:9 aspect ratio from player#36
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the video player incorrectly forced a 16:9 aspect ratio on all videos, leading to distorted playback for content with different aspect ratios. By removing this explicit setting, the player now intelligently defaults to the video's original aspect ratio, significantly improving the visual accuracy and overall quality of video previews. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes a hardcoded 16:9 aspect ratio from the Player component. By deleting art.aspectRatio = "16:9", the ArtPlayer instance will now use its default behavior, which is to respect the video's native aspect ratio. This correctly fixes the described issue of videos being stretched and distorted. The change is sound and I did not find any issues with it.
Summary
Removes the hardcoded
16:9aspect ratio so the player defaults to the video's original aspect ratio.Details
Previously the player instance forced a
16:9aspect ratio:This caused videos with other aspect ratios (e.g., vertical or 4:3 videos) to render incorrectly in the preview unless users manually changed the aspect ratio from the player settings.
By removing this line, ArtPlayer falls back to its default behavior and automatically uses the video's native aspect ratio.
Before / After screenshots
Before
After
Result