Skip to content

fix: Remove forced 16:9 aspect ratio from player#36

Open
EchoDebugger wants to merge 1 commit into
tgdrive:mainfrom
EchoDebugger:main
Open

fix: Remove forced 16:9 aspect ratio from player#36
EchoDebugger wants to merge 1 commit into
tgdrive:mainfrom
EchoDebugger:main

Conversation

@EchoDebugger
Copy link
Copy Markdown

Summary

Removes the hardcoded 16:9 aspect ratio so the player defaults to the video's original aspect ratio.

Details

Previously the player instance forced a 16:9 aspect ratio:

art.aspectRatio = "16:9";

This caused videos with other aspect ratios (e.g., vertical or 4:3 videos) to render incorrectly in the preview unless users manually changed the aspect ratio from the player settings.

By removing this line, ArtPlayer falls back to its default behavior and automatically uses the video's native aspect ratio.

Before / After screenshots

Before

Screenshot_before

After

Screenshot_after

Result

  • Videos display using their correct native aspect ratio
  • Vertical videos render properly
  • Users can still manually adjust the aspect ratio via player settings

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the video player incorrectly forced a 16:9 aspect ratio on all videos, leading to distorted playback for content with different aspect ratios. By removing this explicit setting, the player now intelligently defaults to the video's original aspect ratio, significantly improving the visual accuracy and overall quality of video previews.

Highlights

  • Aspect Ratio Correction: Removed the hardcoded '16:9' aspect ratio setting for the video player, allowing videos to display in their native aspect ratio by default.
  • Improved Video Display: Videos, including vertical and 4:3 content, now render correctly without distortion, enhancing the user viewing experience.
  • User Control Maintained: Users can still manually adjust the aspect ratio through player settings if desired, providing flexibility.
Changelog
  • src/components/previews/video/art-player.tsx
    • Removed the explicit 'art.aspectRatio = "16:9"' assignment to allow the player to use the video's native aspect ratio.
Activity
  • No specific human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a hardcoded 16:9 aspect ratio from the Player component. By deleting art.aspectRatio = "16:9", the ArtPlayer instance will now use its default behavior, which is to respect the video's native aspect ratio. This correctly fixes the described issue of videos being stretched and distorted. The change is sound and I did not find any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant