Skip to content

fix: handle x-client-transaction-id fetch failure gracefully #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohamedorigami-jpg wants to merge 2 commits into from
Closed

fix: handle x-client-transaction-id fetch failure gracefully #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28267e0
fix: getLatestTweet should skip pinned tweet
mohamedorigami-jpg Jun 6, 2026
ba0d2fe
fix: handle x-client-transaction-id fetch failure gracefully
mohamedorigami-jpg Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,16 @@ export async function requestApi<T>(
auth instanceof TwitterGuestAuth &&
auth.options?.experimental?.xClientTransactionId
) {
const transactionId = await generateTransactionId(
url,
auth.fetch.bind(auth),
method,
);
headers.set('x-client-transaction-id', transactionId);
try {
const transactionId = await generateTransactionId(
url,
auth.fetch.bind(auth),
method,
);
headers.set('x-client-transaction-id', transactionId);
} catch (err) {
log('Failed to generate x-client-transaction-id, falling back gracefully: %s', (err as Error).message);
}
}

if (body && method === 'POST') {
Expand Down
16 changes: 10 additions & 6 deletions src/auth-user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,12 +969,16 @@ export class TwitterUserAuth extends TwitterGuestAuth {

// Generate x-client-transaction-id if enabled - real browsers send this during login.
if (this.options?.experimental?.xClientTransactionId) {
const transactionId = await generateTransactionId(
onboardingTaskUrl,
this.fetch.bind(this),
'POST',
);
headers.set('x-client-transaction-id', transactionId);
try {
const transactionId = await generateTransactionId(
onboardingTaskUrl,
this.fetch.bind(this),
'POST',
);
headers.set('x-client-transaction-id', transactionId);
} catch (err) {
log('Failed to generate x-client-transaction-id, falling back gracefully: %s', (err as Error).message);
}
}

// Strip flow_name from the body: real browsers only send it in the URL query parameter.
Expand Down
11 changes: 7 additions & 4 deletions src/tweets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,13 @@ export async function getLatestTweet(
): Promise<Tweet | null | void> {
const timeline = getTweets(user, max, auth);

// No point looping if max is 1, just use first entry.
return max === 1
? (await timeline.next()).value
: await getTweetWhere(timeline, { isRetweet: includeRetweets });
return getTweetWhere(timeline, (tweet) => {
// Skip pinned tweets; they always appear first in the timeline.
if (tweet.isPin) return false;
// If includeRetweets is false, skip retweets too.
if (!includeRetweets && tweet.isRetweet) return false;
return true;
});
}

export interface TweetResultByRestId {
Expand Down