Code Review#7
Conversation
inital files and folder structure
…n either their heading or description
Merging frontend
Pearl footer update
Noodle v1 push to main
theduckfliesagain
requested review from
FaisalY12,
Gingertonic,
Sem-the-dev and
pearlhamilton
Sem-the-dev
left a comment
Sem-the-dev
left a comment
There was a problem hiding this comment.
Comments are from Semhar and Faisal, we think it's great, just added really small suggestions
|
|
||
| footer{ | ||
| background-color:#f1f3f4; | ||
| position: absolute; |
There was a problem hiding this comment.
You might want to remove the position so the footer doesn't move when you open dev tools
|
|
||
| static search(str) { | ||
| const searchResults = resultsData.filter(result => { | ||
| return result.heading.toLowerCase().includes(str) === true || result.desc.toLowerCase().includes(str) === true; |
There was a problem hiding this comment.
You can also add .trim() to the str so it removes whitespace before or after the text (so if someone puts a space before or after their search word it still works)
and add .toLowerCase() to the str so you can search in capital letters too
There was a problem hiding this comment.
Good catch, thanks!
|
|
||
| * Run `npm start` in server folder to launch server. | ||
| * Visit `localhost:3000` in your browser to view the server contents. | ||
| * Run `start index.html` in client folder to launch client. |
There was a problem hiding this comment.
FYI for mac it would be open index.html
|
|
||
| static get random() { | ||
| const randID = Math.floor(Math.random() * resultsData.length); | ||
| console.log(randID) |
There was a problem hiding this comment.
This is showing up on the terminal
|
|
||
| ### Usage | ||
|
|
||
| * Run `npm start` in server folder to launch server. |
There was a problem hiding this comment.
FYI this command won't work on mac, it would be node index.js
There was a problem hiding this comment.
Ah thanks, I think this might have been an issue with our package.json file as well
3 participants
No description provided.