Fixes #39486 - Refactor FormField to PF5#11078
Conversation
| '5.1' | ||
| ); | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
feels strange to see this twice in the same file, I see it's because FormField.js exports also InlineMessage. I found only one use of InlineMessage in a test snapshot. So I wonder if it would be too much of a hustle to either separate that thing into it's own file or just drop it with the snapshot test, that should be dropped sooner or later anyway
|
Should this PR also remove the foreman core usage of FormField ? |
@MariaAga Which usage do you mean? |
|
foreman/app/helpers/tags/react_input.rb Line 13 in e0522f2 Since no place seems to set |
72a2d8e to
1ce59c4
Compare
|
After consultation with @MariaAga rescoped to PF5 refactor |
Deprecation in favor of using PF5 instead