Skip to content

Fixes #39486 - Refactor FormField to PF5#11078

Open
Lukshio wants to merge 1 commit into
theforeman:developfrom
Lukshio:deprecateFormField
Open

Fixes #39486 - Refactor FormField to PF5#11078
Lukshio wants to merge 1 commit into
theforeman:developfrom
Lukshio:deprecateFormField

Conversation

@Lukshio

@Lukshio Lukshio commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Deprecation in favor of using PF5 instead

'5.1'
);
}, []);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels strange to see this twice in the same file, I see it's because FormField.js exports also InlineMessage. I found only one use of InlineMessage in a test snapshot. So I wonder if it would be too much of a hustle to either separate that thing into it's own file or just drop it with the snapshot test, that should be dropped sooner or later anyway

@MariaAga

MariaAga commented Jul 7, 2026

Copy link
Copy Markdown
Member

Should this PR also remove the foreman core usage of FormField ?

@Lukshio

Lukshio commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Should this PR also remove the foreman core usage of FormField ?

@MariaAga Which usage do you mean?

@MariaAga

MariaAga commented Jul 7, 2026

Copy link
Copy Markdown
Member

only_input? ? 'InputFactory' : 'FormField'

import FormField from './common/forms/FormField';

Since no place seems to set only_input, all uses of react_form_input will call FormField

@Lukshio

Lukshio commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

After consultation with @MariaAga rescoped to PF5 refactor

@Lukshio Lukshio changed the title Fixes #39486 - deprecate FormField Fixes #39486 - Refactor FormField to PF5 Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants