Fixes #39532 - All hosts - add action - bulk change proxy - #616
Conversation
MariaAga
left a comment
MariaAga
left a comment
There was a problem hiding this comment.
initial review:
Capsule is for downstream, and gets translated from "Proxy" please only use proxy here.
Going to do some tests now, and then a more in depth review once it gets updated
There was a problem hiding this comment.
Success message doesn't include host count (inconsistent with core bulk actions)
There was a problem hiding this comment.
I tried changing org and location but it does not show count either
pr-processor
Bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
labels
|
Please have a look at this, too: #615 |
MariaAga
left a comment
MariaAga
left a comment
There was a problem hiding this comment.
(midway review as I cant comment on the discussion without clicking "submit review")
Capsule is still mentioned in the code, PR title, and commits.
Also casing should be always OpenSCAP Proxy (and not OpenSCAP proxy)
Lukshio
changed the title
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
I'd also vote for a separate controller over extending the existing one as suggested by @ofedoren . Some nitpicks inline
|
@adamruzicka I updated the PR based on the comments, ready for re-review |
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
the permission check is necessary, the rest is optional
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
One last nitpick, oterwise lgtm
|
Rebase |
MariaAga
left a comment
MariaAga
left a comment
There was a problem hiding this comment.
Tested it with packit and it looks good to me!
(@adamruzicka I dont have permissions to merge 😶 )
5 participants
Users can assign an OpenSCAP Proxy to a host. This can be done individually for a host via the host edit form, but also in bulk via the legacy host overview UI (see screenshot). The new UI currently doesn't support this.
Option can be found on AllHosts page -> select hosts -> kebab menu -> Change association -> OpenSCAP Proxy