fix(compliance): add SCOPED_REQUESTS entries for test_results - #1243
Merged
chris1984 merged 1 commit intoSep 16, 2026
Merged
Conversation
romanblanco
force-pushed
the
RHINENG-28489-tag-filtering-show
branch
from
August 11, 2026 08:08
cf9313c to
182aa54
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
nofaralfasi
approved these changes
Aug 11, 2026
nofaralfasi
left a comment
nofaralfasi
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Non-blocking suggestion: add forward_request tests for the two new compliance test_results endpoints to explicitly assert :tags is present in forwarded params (similar to existing vulnerability forwarding tests).
chris1984
approved these changes
Aug 24, 2026
LadislavVasina1
approved these changes
Sep 4, 2026
Contributor
Author
|
@ColeHiggins2 can we get this merged? |
Without explicit entries, test_results endpoints fall through to the catch-all (api/compliance/v2/.*) which has no tag_name. Foreman won't append ?tags= to forwarded requests, so test results are returned unscoped — any workspace can see any test result regardless of RBAC tag assignments. Add list and show entries with tag_name: :tags before the catch-all, matching the existing pattern for report systems. Signed-off-by: Roman Blanco <rblanco@redhat.com>
romanblanco
force-pushed
the
RHINENG-28489-tag-filtering-show
branch
from
September 11, 2026 09:35
182aa54 to
0555ce5
Compare
Member
Will get this merged today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without explicit entries, test_results endpoints fall through to the catch-all (
api/compliance/v2/.*) which has notag_name. Foreman won't append?tags=to forwarded requests, so test results are returned unscoped — any workspace can see any test result regardless of RBAC tag assignments.Add list and show entries with
tag_name: :tagsbefore the catch-all, matching the existing pattern for report systems.