SAT-48786 - Convert inventory sync Toast tests to RTL - #1249
Merged
jeremylenz merged 1 commit intoSep 1, 2026
Merged
Conversation
pondrejk
approved these changes
Sep 1, 2026
chris1984
approved these changes
Sep 1, 2026
chris1984
left a comment
Member
There was a problem hiding this comment.
LGTM I can't see anything that really stands out. @jeremylenz want to have a final look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Replace the Enzyme
shallowtests for the inventory syncToastwith React Testing Library (SAT-48786).The tests still cover the same cases: all three status counts including
user_omitted, hiding the omitted section when the count is 0 or omitted, and the host-list links for sync / disconnect / user_omitted. They now query by role and visible text (getByRole('link'),getByText) instead of Enzyme wrappers andHostsWithStatusLinkinternals.MemoryRouterwraps the component because it usesLink.No production UI changes.
Considerations taken when implementing this change?
MemoryRoutersoreact-router-domLinkcan render.foremanReact/common/I18n.Dashboard.test.js) alone.What are the testing steps for this pull request?
From the Foreman core checkout (not the plugin directory):