Skip to content

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Dec 5, 2025

Django has a checks framework that can detect problems in a deployment. It's also extensible and allows Pulp and plugin developers to add their own checks. This allows detection of misconfigurations.

Some checks run implicitly before running certain commands but others don't for performance reasons.

--deploy signals that a production setup is used, which enables more checks.

Ideally, we'd also run with --fail-level WARNING, but there are too many warnings right now to fix them all.

https://docs.djangoproject.com/en/5.2/topics/checks/

Django has a checks framework that can detect problems in a deployment.
It's also extensible and allows Pulp and plugin developers to add their
own checks. This allows detection of misconfigurations.

Some checks run implicitly before running certain commands but others
don't for performance reasons.

`--deploy` signals that a production setup is used, which enables more
checks.

Ideally, we'd also run with `--fail-level WARNING`, but there are too
many warnings right now to fix them all.

https://docs.djangoproject.com/en/5.2/topics/checks/
@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2025

This ports @ekohl's theforeman/puppet-pulpcore#155 over to the container world.
Enjoy

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of this makes me think it would be useful as a post install check.

@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2025

The description of this makes me think it would be useful as a post install check.

You mean one that is performed as part of deploy directly?
That's an interesting thought!

@ekohl
Copy link
Member

ekohl commented Dec 5, 2025

In a quadlet you can define a health check. Could we leverage that? This particular check may not be suitable for it, but I'd like to leverage native systemd and podman functionality where possible.

@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2025

Let's continue that discussion in #353

@ehelms ehelms merged commit 2159e72 into master Dec 5, 2025
16 of 18 checks passed
@ehelms ehelms deleted the manager-check branch December 5, 2025 14:41
@ekohl
Copy link
Member

ekohl commented Dec 5, 2025

I'm surprised this passed, but my Puppet version failed with many warnings. Any idea why?

@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2025

Quoting my commit message:
Ideally, we'd also run with --fail-level WARNING, but there are too many warnings right now to fix them all.

@ekohl
Copy link
Member

ekohl commented Dec 5, 2025

Ah yes, now I see it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants