Repository navigation
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
One Large node measured 1,213 s of DKG proving on secure-8192. Live Sepolia holds a 1,800 s window (this file said 1,200 s), which leaves little margin. Use the 7,200 s the example configuration uses.
…onfigured size The Sepolia configuration now lists committee size 3. `upgrade:v19` reads each configured size from the implementation that the batch replaces, and the live Sepolia Interfold reverts without data on size 3, because its `CommitteeSize` has three members. Read that revert as an unset size, so the batch sets it after the upgrade.
…mittee `upgrade:v19` applies the committee thresholds of the configuration but not its timeout windows. Live Sepolia holds a 1800 s DKG window, so the 7200 s of the configuration needs `setTimeoutConfig` in the Sepolia batch.
ctrlc03
force-pushed
the
large/sepolia-cutover-large
branch
from
November 20, 2026 09:48
6ae01bc to
fe5e972
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2537 (
large/release-large); review that one first.Prepares live Sepolia for the Large committee that #2537 routes there.
sepolia-protocol.config.jsonraisesdkgWindowto 7200 s: one Large node measured 1,213 s ofDKG proving on secure-8192. Live Sepolia holds 1800 s (the file's earlier 1200 s was stale). The
value applies to every Sepolia E3: the worst-case committee setup, and CRISP's
earliestVotingStart(), become 8,316 s after the request.upgrade:v19now prepares a batch when the live implementation predates a configured committeesize (Sepolia, size 3): it treats the revert as an unset threshold instead of stopping.
docs/architecture/upgrades.mdstates the Sepolia cutover steps for Large.Verification
Static checks only; CI runs the tests.
tsc --noEmitforinterfold-contracts, prettier,node scripts/blueprint/check.mjs.getTimeoutConfig=(1800, 604800, 21600).Compatibility
setCommitteeThresholds(3, [34, 45])(prepared byupgrade:v19) andsetTimeoutConfig(added by hand); seedocs/architecture/upgrades.md.Follow-ups (not in this stack)
nodeRelease.ts,resumeVrfSortition.ts) now need 45 activeoperators.