feat: add --ssh flag with direct SSH fallback#8
Open
coolaj86 wants to merge 2 commits into
Open
Conversation
Try TLS connection with SSH ALPN first; if the remote doesn't accept it, fall back to a plain TCP connection on the specified port (e.g. 22).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ssh <fallback-port>CLI flag that sets SSH ALPN and enables fallback--ssh 22)dialRemote()helper that encapsulates TLS-first-then-fallback logic, used by both the test connection and per-client connectionsUsage
Tries TLS with
sshALPN on 443 first. If refused, connects directly toexample.com:22instead.Test plan
sclient --ssh 22 telebit.cloud 3000against a server that accepts SSH over TLS — verify TLS path workssclient --ssh 22 github.com 3000against a server that doesn't accept SSH ALPN — verify fallback to port 22sclient example.com 3000without--ssh— verify no behavioral changesclient --ssh 22 --alpn h2 example.com 3000— verify explicit--alpnis not overridden by--ssh