Use instance variable for _in_heading state#13
Merged
thesmallstar merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
Class-level _in_heading is not thread-safe and can get stuck on True if rendering throws between heading_open and heading_close. Move to instance variable initialized in __init__ since the same renderer instance processes the full token stream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for italic inside headings and partial bold headings. Bump version for release with instance variable fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_in_headingfrom a class variable to an instance variable initialized in__init__heading_openandheading_close, the flag would stayTruefor all future rendersTest plan
🤖 Generated with Claude Code