Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07568a4c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _auth_settings: List[str] = [ | ||
| ] |
There was a problem hiding this comment.
This request serializer leaves _auth_settings empty, so ApiClient.update_params_for_auth returns without applying any Authorization header even when Configuration(access_token=...) is provided; in practice, calls to protected connectors endpoints (including this one) are sent unauthenticated and will fail with 401s. The same pattern appears across the new connectors API modules, so these methods should include 'BearerAuth' in their auth settings.
Useful? React with 👍 / 👎.
| # deserialize data into OtherTokenAuthentication | ||
| try: | ||
| instance.actual_instance = OtherTokenAuthentication.from_json(json_str) | ||
| match += 1 |
There was a problem hiding this comment.
The oneOf deserializer attempts BearerTokenAuthentication and OtherTokenAuthentication back-to-back and increments match for each success; because those schemas have the same shape (token plus a non-literal AuthenticationType), valid token-auth payloads can match both and then hit the match > 1 error path, causing GenericConnector.authentication parsing to fail for legitimate API responses. Add discriminator/literal constraints so only one token schema can validate.
Useful? React with 👍 / 👎.
|
superseded by github.com//pull/143 |
2 participants
No description provided.