Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a52804eeef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def test_set_generic_connector_operations_models_validation(self) -> None: | ||
| """Test case for set_generic_connector_operations request and response models""" | ||
| request_body_json = """ |
There was a problem hiding this comment.
The request_body_json = """ literal is never closed before Python statements resume, which makes this test module fail to import (IndentationError is raised during collection). Because the CI workflow runs coverage run --source=$module -m pytest $module for each SDK module in .github/workflows/python.yaml, this syntax error causes the connectors module test step to fail consistently.
Useful? React with 👍 / 👎.
|
|
||
| def test_set_operation_connectors_models_validation(self) -> None: | ||
| """Test case for set_operation_connectors request and response models""" | ||
| request_body_json = """ |
There was a problem hiding this comment.
This request_body_json triple-quoted string is left open, so the following statements are parsed as part of the string and pytest collection aborts with an IndentationError. In the current CI loop (.github/workflows/python.yaml), that means the connectors test run cannot execute at all and the build fails on every run that includes this commit.
Useful? React with 👍 / 👎.
|
superseded by #143 |
2 participants
No description provided.